Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Omni logs #30322

Merged
merged 7 commits into from
Sep 29, 2023
Merged

refactor: Omni logs #30322

merged 7 commits into from
Sep 29, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

PR aims to:

  • Reduce the number of logs from features that didn't had any recent issues (6+ months)
  • Remove logs that were duplicated
  • Increase the log level of some actions, so we/users know they're being performed (service activation, queue processing, etc)
  • Remove "unnecessary" logs on some callbacks (we didn't debug any error on these recently, so it's safe to remove them now)

Issue(s)

Steps to test or reproduce

Further comments

TODO: Draft with BE chapter a proposal on logging strategy and best practices :)

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 8ff2024

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #30322 (8ff2024) into develop (430c7be) will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30322      +/-   ##
===========================================
- Coverage    50.93%   50.61%   -0.33%     
===========================================
  Files          809      803       -6     
  Lines        15016    14995      -21     
  Branches      2724     2720       -4     
===========================================
- Hits          7649     7589      -60     
- Misses        6958     6982      +24     
- Partials       409      424      +15     
Flag Coverage Δ
e2e 48.23% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review September 12, 2023 15:23
@KevLehman KevLehman requested review from a team as code owners September 12, 2023 15:23
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 12, 2023
…BeforeTakeInquiry.ts

Co-authored-by: Murtaza Patrawala <[email protected]>
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 14, 2023
@KevLehman KevLehman added this to the 6.5.0 milestone Sep 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@kodiakhq kodiakhq bot merged commit bb5fe78 into develop Sep 29, 2023
@kodiakhq kodiakhq bot deleted the refactor/omni-logs branch September 29, 2023 17:44
gabriellsh added a commit that referenced this pull request Oct 3, 2023
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants